Looks great Padraig, much better interaction. Works well for single and All Publishers. Just curious why you did the name change at:

    3687 +                pkg_fmri = app[enumerations.FMRI_COLUMN]
    3688 +                if pkg_fmri:
    3689 +                        pkg_name = pkg_fmri.get_name()

JR

Padraig O'Briain wrote:
Thanks for picking this up. I believe that the new webrev fixes the problem.
http://cr.opensolaris.org/~padraig/ips-11278-v2/

Padraig

On 10/08/09 20:28, Joanmarie Diggs wrote:
Hey Padraig.

It doesn't seem to be working when searching multiple publishers at
once. Simple test:

1. Switch to Search All
2. Search for 'dasher'
3. Check the checkbox associated with SUNWgnome-a11y-dasher
4. Select opensolaris.org in the Publisher combo box
5. Select Selected Packages in the View combo box

I get nothing in the resulting list. I'd expect to get the marked
package. (And I do when I only search a single publisher.)

Take care.
--joanie

On Thu, 2009-10-08 at 11:29 +0100, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-11278-v1/, fixes
11278 PackageManager should maintain selections across searches and publishers
11809 Install/Update button not set correctly after search

If a user selects a package and does a search and the package is in the search results it will be selected. Similarly, if the user selects a package after doing a search and then goes to the publisher containing that package the package will remain selected.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to