Respun the webrev, http://cr.opensolaris.org/~padraig/ips-11806-v2/ , to
address these issues.
Padraig
On 10/12/09 12:17, jmr wrote:
Tested and looks good. Comments on the code:
This chunk is going as part of webrev 11278 so shouldn't be in this one:
2440 2430 def __unset_search(self, same_repo):
2441 2431 self.w_infosearch_frame.hide()
2442 - selected_publisher =
self.__get_selected_publisher()
2443 - if selected_publisher in self.selected_pkgs:
2444 -
self.selected_pkgs.pop(selected_publisher)
2445 - if selected_publisher in
self.to_install_update:
2446 -
self.to_install_update.pop(selected_publisher)
2447 - if selected_publisher in self.to_remove:
2448 - self.to_remove.pop(selected_publisher)
Why the need to move these? Don't think we should be effecting the
update_statusbar() code now after the earlier changes.
3995 - self.__enable_disable_install_remove()
3996 3946 self.update_statusbar()
3947 + self.__enable_disable_install_remove()
4179 - self.__enable_disable_install_remove()
4180 4130 self.update_statusbar()
4131 + self.__enable_disable_install_remove()
JR
Padraig O'Briain wrote:
Sorry, wrong webrev:
http://cr.opensolaris.org/~padraig/ips-11806-v1/
On 10/09/09 11:03, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-11278-v2/, fixes
11806 PM installs packages even if they are not checked
11310 Some inconsistencies in coding in packagemanager.py
This webrev ensure that only packages which have been explicitly
selected by the user are installed or removed.
That change removed the calls to
if self.selected == 0:
gobject_idle_add(self.__enable_disable_install_remove)
complained of in bug 11310.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
