LGTM. I'd lean towards those tests being under t_pkgdep_resolve rather
than t_pkgdep, but I don't feel strongly about it if you think they
should live where they are. Whichever you decide, I don't need to see
this again.
Brock
John Sonnenschein wrote:
John Sonnenschein wrote:
Brock Pytlik wrote:
John Sonnenschein wrote:
Brock Pytlik wrote:
John Sonnenschein wrote:
http://cr.opensolaris.org/~error404/pkgdep_fixes/
Thanks
-JohnS
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Please add test cases for each of these bugs.
For line 136, maybe something like: "Could not parse the manifest
because of the following line"
For bug 10518, it probably makes sense to add similar checks to
pkgdep resolve as well. Does resolve blow up when handed a bad
manifest? Might as well catch that as well.
Thanks, fixed:
http://cr.opensolaris.org/~error404/pkgdep_fixes_2/
-JohnS
In general looks good, only a few nits.
Comments for each test case please. (I know that the one above the
ones you added doesn't have any, but it should.)
t_pkgdep.py
488-489, probably can remove these empty lines
496,497,502,503 4 space indentation please.
pkgdep.py
136 the error message should be translated and please use the
dictionary approach with string replacement when replacing more than
one value. If you felt like fixing 132 so it's translated as well,
that'd be great.
137 4 space indentation please
226 remove empty line
This should take care of it:
http://cr.opensolaris.org/~error404/pkgdep_fixes_3/
-JohnS
ping
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
