I have respun the webrev, http://cr.opensolaris.org/~padraig/ips-11646-v3/.
Responses to your comments are below.
Padraig
On 10/19/09 10:28, jmr wrote:
Padraig,
Some comments below:
This description needs changed and this is not a user settable
options, looks like a copy and paste from the save_state key.
<short>Display selected publisher at startup</short>
182 + <long>
183 + A boolean which determines whether Package Manager
should start
184 + in search mode.
Logic where if self.lastsource == ALL_PUBLISHERS is being used needs
to be kept. I know lastsource can no longer == ALL_PUBLISHERS, but we
need to test the new gconf key here to see if we are in that state.
See this in a few places.
I would use code similar to __get_publisher_combobox_index() to get
the name from index rather than setting the combobox:
3057 +
self.w_repository_combobox.set_active(
3058 +
self.saved_repository_combobox_active)
3059 + sel_pub =
self.__get_selected_publisher()
Why did you mov self.first_run? Need to check there are no side
effects in unsetting this earlier.
def process_package_list_end(self):
4359 4361 self.in_startpage_startup = False
4360 4362 if self.update_all_proceed:
4361 4363 # TODO: Handle situation where only
SUNWipkg/SUNWipg-gui have been updated
4362 4364 # in update all: bug 6357
4363 4365 self.__on_update_all(None)
4364 4366 self.update_all_proceed = False
4365 4367 self.__enable_disable_install_remove()
4366 4368 self.update_statusbar()
4369 + if self.first_run:
4370 + self.first_run = False
JR
Padraig O'Briain wrote:
I have reworked the webrev,
http://cr.opensolaris.org/~padraig/ips-11646-v2/, so that the start
page is shown.
Padraig
On 10/09/09 14:58, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-11646-v1/,
attempt to fix
11646 Restoring All Publisher should also restore last viewed
publisher categories
The webrev does as suggested in the bug; i.e. restores the previous
publisher before switching to search mode. The only problem with
this is that the start page does not remain shown.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
