Padraig - great, good news on the gtk version. The code change looks good to me. I will test it tomorrow morning when I'm on a build machine.

JR

Padraig O'Briain wrote:
jmr wrote:
Padraig,

Couple of things. Can you check if the has tooltip is supported in the version of Gtk running with 2009.06, think it was 2.10, but you'd need to double check.

The version in 2009.06 is 2.14.5. Current version is 2.18.0.
New tooltips were added in 2.12.

When I apply and run the patch its not quite working for me.
I have spun a new webrev, http://cr.opensolaris.org/~padraig/ips-12020-v3/.
The change to fix this is line 2693.

Mouse over the Status column and pause
- Tooltip is displayed for that row correctly with the correct status (Installed or Not Installed) - Move the mouse down the column, pausing on each row. The text in the tooltip changes to reflect whatever row its on, but the tooltip doesn't move with the cursor. Its stuck on the row it first appeared on, you need to move the cursor out of the status column and back in again to get it to display in the correct location.

Expected behavior:
- The tooltip should disappear after you move the mouse and be redisplayed on the row the mouse is currently paused over.

JR

Padraig O'Briain wrote:
I have respun the webrev, http://cr.opensolaris.org/~padraig/ips-12020-v1/.

I have confirmed that it works on build 125 and 123.

Padraig

On 10/19/09 11:51, Padraig O'Briain wrote:


On 10/19/09 11:47, Joanmarie Diggs wrote:
Understood. And now that build 125 is externally available, it's no
longer an issue for me personally.

Silly question: Will this have any impact on GUI users performing an
update (i.e. when you're prompted to install SUNWipkg in order to be
able to do the update)?


Not a silly question but one that I am currently working on. I am currently checking whether I can get it to work on 2009.06.

Padraig
On Mon, 2009-10-19 at 07:46 +0100, Padraig O'Briain wrote:
The problem in bug 12020 was reported on OpenSolaris 125 which has gtk
version 2.18.0. OpenSolaris 124 has gtk version 2.17.10.

One consequence of this change  is that it will not be possible to
back publish PackageManager to previous builds on OpenSolaris.

Padraig

On 10/16/09 16:33, Joanmarie Diggs wrote:
I'm still on build 124. With this webrev applied, I cannot launch PM at
all.

Traceback (most recent call last):
  File "/usr/bin/packagemanager", line 4656, in ?
    packagemanager = PackageManager()
  File "/usr/bin/packagemanager", line 493, in __init__
    self.__setup_startpage(self.show_startpage)
  File "/usr/bin/packagemanager", line 782, in __setup_startpage
    self.__load_startpage()
  File "/usr/bin/packagemanager", line 798, in __load_startpage
    if self.__load_startpage_locale(START_PAGE_CACHE_LANG_BASE):
File "/usr/bin/packagemanager", line 807, in __load_startpage_locale
    if self.__load_uri(self.document, self.start_page_url):
  File "/usr/bin/packagemanager", line 924, in __load_uri
    self.__update_statusbar_message(_("Stopped"))
  File "/usr/bin/packagemanager", line 1714, in
__update_statusbar_message
self.w_main_statusbar.remove_message(0, AttributeError: 'gtk.Statusbar' object has no attribute 'remove_message'

--joanie

On Fri, 2009-10-16 at 15:32 +0100, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-12020-v1/, fixes
12020 Launch PM with warnings on OpenSolaris 125

This webrev fixes warnings about deprecations emitted for statusbar and tooltip.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss



_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to