Thanks for looking at this. On Tue, Oct 27, 2009 at 11:07:01AM -0500, Shawn Walker wrote: > [email protected] wrote: >> I've updated this webrev after merging with Shawn's catalog/1 work. It >> also contains a few minor additonal bugfixes. If someone has time to >> give this another quick look, I'd appreciate it. >> >> http://cr.opensolaris.org/~johansen/webrev-qual-2/ > > modules/client/transport/stats.py: > line 123: extra whitespace?
Fixed. > line 683: success doesn't get assigned in the gave_up case; is the > assumption that it was assigned on 673? could this cause a problem at > line 708? The exception handler at line 667 sets gave_up to True and assigns a list to success by getting information out of the exception. Unless I've missed something, that exception handler is the only place where gave_up gets set. In the cases after "if gave_up" the list of successful requests has to be computed since only the ExcessiveTransientFailure exception returns the successful and failed reqeusts. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
