Padraig - my pylint change clashed with yours, this is applying cleanly:

http://cr.opensolaris.org/~jmr/pm_12203_search_error_feedback_30Oct_420pm/
12203 PM Search error and help page UI feedback

JR

Padraig O'Briain wrote:
The patch does not apply to the gate.

Padraig

On 10/30/09 16:12, jmr wrote:
Thanks Padraig - new webrev:

http://cr.opensolaris.org/~jmr/pm_12203_search_error_feedback_30Oct_410pm/
12203 PM Search error and help page UI feedback

Pylint warnings at 1834, 1835, 1839, 1840, 1906.
Ok

__setup_search_zero_filtered_results_page:
Should the issue raised in http://defect.opensolaris.org/bz/show_bug.cgi?id=12026
cause you to change the translated strings?
Was wondering about this, looking at Joanie's patch in 12026 this makes sense to do here as well, even though we are using singular/plural constructs later in the sentence not just for 'package(s)'.

JR



Padraig

On 10/29/09 12:47, jmr wrote:
Hi - webrev to cover various search error UI feedback, see bug for details.

http://cr.opensolaris.org/~jmr/pm_12203_search_error_feedback_29Oct_1230pm/
12203 PM Search error and help page UI feedback

JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to