I'm still hoping that somebody will push this for me before I need to
worry about rebasing it.

Patch attached (again) for reference.

--Mark

On Sat, Oct 31, 2009 at 11:00:20AM -0600, Mark J. Nelson wrote:
> >> Thank you for the review, and for figuring out what I was doing wrong.
> >>
> >> I'm getting two mismatches, with or without my changes applied.
> >>
> >> I'll doublecheck it and send a patch sometime this weekend.
> >
> > Can you post the test log somewhere?  You may not be to blame for those  
> > either :)
> >
> > Their shouldn't be any known gate mismatches at this time though.
> 
> I updated to tip and retested with and without my changes, and I am
> seeing 
> 
> > FAILED (successes=323, failures=1, errors=1, mismatches=0)
> 
> for both cases.
> 
> I attached the patch, I think it's suitable for somebody to push.
> Thank you.
> 
> --Mark

> # HG changeset patch
> # User Mark J. Nelson <[email protected]>
> # Date 1257004121 21600
> # Node ID 961ac1352af50c7380cc3d78a257f51a56d2f071
> # Parent  54133287c1c50346e119ff67281b80b7bb5c0d60
> 12352 pkgsend error message should list path attribute, not hash
> 
> diff --git a/src/publish.py b/src/publish.py
> --- a/src/publish.py
> +++ b/src/publish.py
> @@ -320,7 +320,7 @@
>  
>                                  if not os.path.isfile(data):
>                                          error(_("line %s: File %s not 
> found") %
> -                                            (lineno + 1, args[1]),
> +                                            (lineno + 1, filepath),
>                                              cmd="include")
>                                          error_occurred = True
>                                          continue

> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

# HG changeset patch
# User Mark J. Nelson <[email protected]>
# Date 1257004121 21600
# Node ID 961ac1352af50c7380cc3d78a257f51a56d2f071
# Parent  54133287c1c50346e119ff67281b80b7bb5c0d60
12352 pkgsend error message should list path attribute, not hash

diff --git a/src/publish.py b/src/publish.py
--- a/src/publish.py
+++ b/src/publish.py
@@ -320,7 +320,7 @@
 
                                 if not os.path.isfile(data):
                                         error(_("line %s: File %s not found") %
-                                            (lineno + 1, args[1]),
+                                            (lineno + 1, filepath),
                                             cmd="include")
                                         error_occurred = True
                                         continue
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to