Dan Price wrote:
On Mon 02 Nov 2009 at 02:16PM, Bart Smaalders wrote:
I'm working on a command to facilitate publication of packages
using native manifests.  The man page so far is attached....

- Bart

Hey Bart,

Like the C compiler, you could, for convenience's sake, set
up some conventions around certain macros which are always
set.  sparc_ONLY, i386_ONLY, ARCH64, etc. sure seem like good
candidates.  You could always offer a command line option which
omits these defaults for the control freak.

This would seem to have the effect of making the usage more
uniform across users of this tool-- users would be more likely
to utilize the macro names you have provided, and less likely
to gratuitously decide on different names.

The only other thing I think this needs is observability.  A -v or some such
which shows me the input and output (and the rules which were applied) would be
super helpful for debugging.  You could even optionally have that output be
placed into the resultant manifest as comments:

# input action: file path=var/svc/manifest/system/system-log.xml # applied rule: <transform file path=var/svc/manifest/.*\.xml -> add restart_fmri svc:/system/manifest-import:default>
# applied rule: <transform file path=var/svc/manifest/.*\.xml -> add mode 0444>
# applied rule: <transform file path=var/svc/manifest/.*\.xml -> add group sys>
# applied rule: <transform file path=var/svc/manifest/.*\.xml -> add group 
owner>
file path=var/svc/manifest/system/system-log.xml group=sys mode=0444 owner=root 
path=var/svc/manifest/system/system-log.xml 
restart_fmri=svc:/system/manifest-import:default

This would make it obvious to someone how this was working.

        -dp


I like the -v option; I'll add that. It will display the effect of transforms but not of macros.

Predefining macros seems difficult, since I'd certainly like to
imagine a cross-compilation environment working.

- Bart

--
Bart Smaalders                  Solaris Kernel Performance
[email protected]         http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to