On Fri, Nov 13, 2009 at 06:17:58PM -0600, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains changes for the following bugs:
>
> 9969 client support for multiple origins desired
> 11715 ImageConfig does not handle None for publisher correctly
> 11793 image-create example partially disagrees with the usage
>
> This adds the long-awaited multiple origins support to the client
> while retaining some level of basic compatibility with older
> clients.
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-origins/
>
> I need zone experts to review this; I've done some of my own testing
> (attach, detach, create, etc.) but this is my first foray into
> zones-related changes.
>
hey shawn,
thanks for fixing this up.
i reviewed just the zones changes.
my comments are below.
ed
- detach: no delta
- attach and pkgzonecreate: debugging code
- attach: why:
echo $(get_publisher_urls ...) |
instead of just
get_publisher_urls ... |
- pkgzonecreate: you updated the usage error messages to mention some
new flags. -g and -m. but i don't see these flags used anywhere.
- pkgzonecreate: you removed the return code from get_publisher_urls(),
so this comparison seems unnecessary: "$? -eq 0"
- pkgzonecreate: when creating publishers_extra_origins and
spublishers_extra_mirrors, you could switch to using a space seperator
instead of a newline. (i used newline because in the old code that was
easier for parsing, but now you're redefining IFS to newline to work
around then when if you had them seperated by spaces it would be
easier.) doing this would also allow you to eliminate a bunch of -z
comparisons.
- attach and pkgzonecreate: unless you've redefined IFS to something
other than whitespace, the -z in many of the following constructs
seems unnecessary:
for XXX in $YYY; do
[[ -z "$XXX" ]] && continue
- common.ksh: the following clause "END{exit(0)}" is no longer necessary
in the nawk statement. (shell pipelines only return the error code of
the last command in the pipeline.)
- common.ksh: if "pkg publisher" doesn't have any output (or none of the
output makes it past nawk), you'll either print out an empty line or
the last line from when the function was previously run.
- common.ksh: you might want to add some kind of return code to
get_publisher_urls().
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
