Tested v4 against the gate. All coding issues addressed. Putting in all
the various characters that caused issues before, switching between
Pubs, testing within search results list for single and all. All works
fine for me.
+1
JR
Joanmarie Diggs wrote:
Here's take 4: http://defect.opensolaris.org/bz/attachment.cgi?id=3031
Addresses:
1. We should also be catching re.error as well as TypeError. (Thanks
John!)
2. Switching publishers causes the feature to fail in the category
treeview. It turns out the search column was getting reset. (Thanks
Michal!)
--joanie
On Mon, 2009-11-16 at 08:52 -0500, Joanmarie Diggs wrote:
New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025
Hopefully addresses:
1. Michal's tracebacks. (Thanks for catching that. Sorry it needed
catching. :-/)
2. John's suggestion to pull out the re.compile.
3. Padraig's observation from pylint that my compare "functions" could
be functions.
4. Padraig's traceback.
5. Wrapped the re stuff in a try/except just in case.
Please review. Thanks!
--joanie
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
