Some initial comments:
packagemanager-preferences.schemas.in:
There is a full stop at line 198 which I believe should not be there.
gui_pylintrc: Change from 5000 to 6000 seems excessive. Would 5100 do?
Should Ann Kanodia be added to the list of names in the glade file?
Are we having separate checkboxes for Check for Updates and Install/Update?
I do not see it in the wireframe and I thought we were going to use one
checkbox for both.
There was some discussion of changing "Check for Updates" to "Updates".
I do not see a bug for this and you do not seem to be doing this in this
webrev.
In Remove confirmation dialog should the title be "Remove Confirmation"?
In Update all confirmation should the title be "Update All Confirmation"?
Should the packages in this list be sorted by name?
I find the existence of the expander in this dialog very strange. Should
this be just a label which is not shown if there are no packages to be
removed?
Should there be more space between the label and the treeview below it?
The dialog does not seem to be resizable. Should it be? I might want to
see all the description.
More comments tomorrow!
Padraig
On 11/19/09 15:53, Michal Pryc wrote:
Hello,
I have prepared webrev for the bug:
12108 Add "Do not prompt" checkbox on confirmation dialogs
http://defect.opensolaris.org/bz/show_bug.cgi?id=12108
Which also adds one part which was described in the comment #1 for bug:
12297 Change Update All to Check for Updates
http://defect.opensolaris.org/bz/show_bug.cgi?id=12297
The webrev is available at:
http://cr.opensolaris.org/~migi/12297_check_for_updates_ver1/
It implements new confirmation dialog for Package Manager together
with adding hooks to the preferences dialogs and gconf keys.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
