This looks good to me.
Padraig
On 11/20/09 15:10, Michal Pryc wrote:
Padraig,
Here is the webrev with my proposal:
http://cr.opensolaris.org/~migi/12685_v1/
Michal
Michal Pryc wrote:
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-12685-v1/, fixes
12685 Pressing PM's Update All/Check For Updates button while Orca
is running will hang both PM and Orca
I am submitting this patch on behalf of Joanmarie Diggs.
The fix is to move GUI related code out of background thread and
into the main thread.
I believe that much nicer fix would be to change the installupdate.py:
self.uarenamebe_o = \
uarenamebe.RenameBeAfterUpdateAll(
self.parent,
self.icon_confirm_dialog,
self.w_main_window)
to wrap it as function run this code from gobject.idle_add().
So change the above code to:
gobject.idle_add(self.__create_uarenamebe_obj)
and move it to the function:
def __create_uarenamebe_obj(self):
self.uarenamebe_o = \
uarenamebe.RenameBeAfterUpdateAll(self.parent,
self.icon_confirm_dialog, self.w_main_window)
best
Michal
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
