I think that it is reasonable that only the actions which are displayed in Manage Publishers Confirmation dialog are canceled.

These currently are enable/disable and remove a publisher but not adding or modifying a publisher. The cancel button in Add Publisher or Modify Publisher dialog should deal with those.

That said, we currently do not display enable/disable status correctly after cancel.

The updated webrev, http://cr.opensolaris.org/~padraig/ips-12572-v2/, deals with that.

Padraig

On 11/23/09 19:16, Joanmarie Diggs wrote:
Hey Padraig.

That seems to nicely solve the reported problem. I noticed, however,
that canceling the action doesn't cancel changes made from adding a
publisher or modifying an existing one either. Separate bug, or should
PM be doing a blanket restore of the way things were w.r.t. publishers
when that Cancel button is pressed?

Take care.
--joanie

On Mon, 2009-11-23 at 13:14 +0000, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-12572-v1/,
12572 When Removing publisher, if cancel the action, the publisher no longer appears in "Manage Publishers" list

The fix is to redisplay any publishers which were marked for removal after the cancel operation. The other changes are to fix pylint warnings.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to