What problem is the addition and changes of calls to
gui_misc.set_modal_and_transient()
addressing?
What problem will occur if lines 1084-1085 or 1184 is omitted?
Are lines 1057 to 1060 omitted because we must always have something
selected in the publisher treeview?
Typo at line 1512 priortiy->priority
On further reflection I find this comment confusing.
How about:
"""If we remove a publisher from our model, the priorities of
subsequent publishers are decremented. We need to ignore the
priority changes caused solely by publisher(s) removal.
This function returns True if the priority change for a publisher
is due to publisher(s) removal or False otherwise."""
Alignment issue at line 1786.
Padraig
On 11/26/09 11:41, Michal Pryc wrote:
Hello,
The webrev:
http://cr.opensolaris.org/~migi/12179_v4/
Fixes the bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=12179
How this works?
The user plays with the publishers by removing, enabling, disabling
and at the same time changing the priorities. We need to make sure
that the change of the priority is permitted, so we need to
disable/enable up/down buttons depending on the current publisher
state, priority and it's neighbours.
Once the publisher priorities are changed we need to apply them first
before any other action as the user might want to remove the publisher
which is currently highest priority and change other publisher to have
the highest priority. Applying this in vice-versa order would not
permit to remove the highest priority publisher.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
