Danek Duvall wrote:
test_unobsoleted:What this does now is ensure that we skip over the obsoleted version when we image update. I think it should also test that, from an empty image, installing the package without specifying any version, it installs v3. The docstring could use a bit of cleanup. I'll suggest: Ensure that the existence of an obsolete package version does not prevent the system from upgrading to or installing a resurrected version. And then you might put comments into the body of the test saying what you're doing where (see my recent user action testcases for an example). You should be checking explicitly for reint...@3. test_unobsoleted_dependency: Line 3777 is not strictly needed, as B will drag in A because of the dependency. I think it would also be useful to do a test where you skip straight to the v3 packages. Like a...@1, you shouldn't have to install a...@3 explicitly. In fact, what we really want to test here is that installing b...@3 pulls A across the obsoleted version just fine. Don't care about list reintrodepB, but list reintrodepA should be @3. The same comment as for test_unobsoleted -- test installing @3 from an empty image, too. So you should have three scenarios: empty -> @3 @1 -> @2 -> @3 @1 -> @3 In fact, the @1 -> @2 -> @3 is missing from test_unobsoleted; you should probably add that scenario, too. You could combine these two tests: publish A & B @1, 2, and 3, and just play with A first (the unobsoleted tests), then play with B (the unobsoleted_dependency tests), and just clear out the image in between. You don't need to use image-update; install with a particular version should be fine for the test.
I think I've covered everything you suggested. I combined the two tests, added individual comments. I also left the two image-update sub-tests in as well. New webrev at: http://cr.opensolaris.org/~richb/pkg-13091-v2/ Output from running the test at: http://cr.opensolaris.org/~richb/pkg-13091-v2/output.txt Thanks! _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
