* [email protected] <[email protected]> [2009-12-11 23:53]:
> On Wed, Dec 09, 2009 at 02:45:34PM -0800, [email protected] wrote:
> > Folks,
> > The following webrev implements API support for canceling a search
> > operation. The GUI will make use of this functionality. A webrev is
> > available from the location below:
> >
> > http://cr.opensolaris.org/~johansen/webrev-8584/
>
> Thanks to those of you who have reviewed this already. I have generated
> a new webrev and posted it at the location below:
>
> http://cr.opensolaris.org/~johansen/webrev-8584-2/
>
> Can I get one more reviewer to take a look at this change? I'm
> particularly interested in getting someone's eyes on the lock/cv usage
> in the API. I believe that I've caught the corner cases, but I would
> appreciate a second opinion. :)
I think I have mapped the threading conventions for CVs onto my uts
thinking. No test cases? (Bug in test category, please.)
api.py:
207. What would cause api_errors.CanceledException to be raised
here?
328. I wonder if
self.__cancel_lock.acquire()
if self.__canceling:
self.__cancel_lock.release()
raise api_errors.CanceledException()
else:
self.__set_can_be_canceled(False)
self.__cancel_lock.release()
should be a function. It seems to recur as a test for
cancellation requested.
1652. (Sp.) "canelation" -> "cancelation".
engine.py:
770. Who's expected to use progfunc of our current clients?
transport.py:
106. Shouldn't this be
fobj = self._do_search(pub, data, ccancel=ccancel)
? Similarly on 188, 519, 559, 1099, 1121, 1317, and maybe one
or two more.
1280. Can just omit ccancel here.
1327. Tracking bug?
- Stephen
--
[email protected] http://blogs.sun.com/sch/
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
