Thanks Padraig

Padraig O'Briain wrote:
There is a pylint warning about unused import in misc_non_gui.py.
Removed

You have added unnecessary spaces in the line before gui_misc.shutdown_logging() in packagemanager.py.
Removed

Should you add the logging to webinstall.py?
Yep - I added this and have changed:
PKG_CLIENT_NAME to "packagemanager-webinstall" so we can identify webinstall from packagemanager logs.

New webrev:

http://cr.opensolaris.org/~jmr/pm_12240_logging_support_14Dec_1220pm/
12240 PM / UM need to intercept and display client messages


JR

Padraig

On 12/10/09 21:50, John Rice wrote:
Hi - this webrev adds logging handlers to the PM and UM. For now they are just outputting to tmp files:

/var/tmp/packagemanager_info.log
/var/tmp/packagemanager_error.log
var/tmp/updatemanager_info.log
/var/tmp/updatemanager_error.log

Post 2010.03 we can look at hooking them into the GUI so the user can view them directly from the GUI, but this will be tracked as a separate enhancement from this bug.

http://cr.opensolaris.org/~jmr/pm_12240_pm_logging_10Dec_940pm/
12240 PM / UM need to intercept and display client messages

JR

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to