Rich, Takeshi,

I have prepared webrev which fixes 13153. I would like to ask you to approve this webrev *only* if there are no implications on your side.

http://cr.opensolaris.org/~migi/13153_category_support_v3/

Part important for Rich:
 
http://cr.opensolaris.org/~migi/13153_category_support_v3/src/util/distro-import/gen_os_files.py.wdiff.html
- This webrev allows PM to have the same category names in the different sections, so we do not need to make adjustments for the category names.

Part important for Takeshi:
 l10n changes:
   - src/gui/data/l10n.py
     Five strings removed:
        _("Databases (System)")
        _("Libraries (System)")
        _("Localizations (Desktop)")
        _("Localizations (System)")
        _("X11 (System)")

     One string added:
        _("Localizations")

--
best
Michal Pryc


On 21/12/2009 17:20, Padraig O'Briain wrote:
Should you update l10n.py following your change to opensolaris.org.sections?

The code changes look good to me.

Padraig

On 12/21/09 15:47, Michal Pryc wrote:
Hello,
The webrev:
http://cr.opensolaris.org/~migi/13153_category_support_v2/

Fixes the bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=13153

There were two aspects to be solved:
 1. Allow the same category name be in the different sections.
2. If the category is not in the opensolaris.org.section schema, which is the supported fully localized one, then clicking on the main section should allow user to see the package. In this example the category should not be visible in the main categories view.

--
best
Michal Pryc


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to