On 01/ 8/10 03:26 PM, Brock Pytlik wrote:
Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issues:

6284 depot should support --help and -? options
13764 pkg.depotd usage message could be less verbose

webrev:
http://cr.opensolaris.org/~swalker/pkg-6284/

Please note that the --help and -? is being used for consistency with
the client. I have no personal preference here.

Only comment is that if text is not true and full is false, the message
shown the user is only:

"Try `pkg.depotd --help or -?' for more information."

I think if text is not true, something like, "An unknown error occurred"
or something similar should appear.

That particular case never actually exists for the depot. The only time a message isn't provided to usage() is when the full, standard usage message is requested. So for now, I think i'll skip this bit.

--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to