On Fri, Jan 08, 2010 at 04:23:11PM -0600, Shawn Walker wrote:
> On 01/ 8/10 04:12 PM, [email protected] wrote:
> >I'm posting a new webrev with the API and locking changes included.
> >
> >http://cr.opensolaris.org/~johansen/webrev-13746-2/
> 
> Final questions are:
> 
> * Does calling transport.shutdown() affect transport.stats.dump() at
> all?  Was hoping that PKG_MIRROR_STATS, etc. will still work just
> fine.

No, shutdown and reset don't touch the stats.  However, if the API is
reset it will create a new Image and Transport, and those will have
their own statistics.

> * If an exception gets raised during plan execution, doesn't this
> mean that the connections won't get closed in the GUI?  (See line
> 788 of imageplan.py).

What problem are you worried about here specifically?  The GUI calls
api.reset() prior to performing an InstallUpdate, so if the first
install fails the old transport will get shutdown before a new transport
is created.

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to