[email protected] wrote:
On Mon, Jan 11, 2010 at 01:20:00PM -0800, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-13791-v1/

This looks okay.  You're letting the fd for stdout remain the one that
was inherited from the parent process, though.  Is it necessary to print
the command that failed if everything else is getting logged to stdout
for the test suite already?

-j
There's sample output in the bug. To me, it seemed appropriate, but if you'd like something different, please let me know. I thought printing the exact command would be helpful instead of trying to reconstruct it from the test or the errors.

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to