On Thu, Jan 14, 2010 at 09:50:32AM -0600, Tom Mueller wrote: > Has there been any thought given to the idea of using the ELF > comparison at publish time so that when a file is published with the > same ELF content as a file that is already in the repository, no new > file would be created in the repository, and the action would be set > so that the hashval is the same as the existing file? This would > eliminate the need for having ELF hashes in actions and would still > get the benefit of reducing downloads for "unchanged" ELF files, > while at the same time eliminating this problem of having files on > different systems that are both the "same" and "different" > (depending on how the files are compared).
This is only appropriate if the elfhash_old == elfhash_new && hash_old == hash_net && chash_old == chash_new If you don't follow this, you'll end up introducing regressions as the action attributes and file formats have changed over time. There are a number of scenarios where we need to re-write the binary, even if the content is identical, because the gzip format changed. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
