LGTM
JR
Padraig O'Briain wrote:
I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-13926-v2/, to catch
CertificateError instead of NotYetValidCertificateException.
I do not think that we need to refer to this exception elsewhere.
In do_refresh this exception can be thrown but it is caught by
ApiException.
Padraig
On 01/18/10 09:46, John Rice wrote:
This looks fine Padraig, but there are a lot of other
CertificateExceptions, should we we be catching them also, can we
catch the base exception, are there other places in the code where we
could hit this exception type? I know the global error handler will
catch any we miss, but as you are looking at it no harm to do a review.
Thanks.
JR
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-13926-v1/ ,
13926 PM displays traceback for certificates with a future effective
date
This webrev just catches the exception NotYetValidCertificateException.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
