This looks good to me.
pylint reports Unused import pkg at line 50.
Padraig
On 01/19/10 14:33, Michal Pryc wrote:
Padraig,
New webrev at:
http://cr.opensolaris.org/~migi/13858_v2
best
Michal
On 01/18/10 03:42 PM, Padraig O'Briain wrote:
At line 28 of installupdate.py I suggest
'consists of frame' should be'consist of frames'.
When I tested it all the packages to be removed in Update All
Confirmation dialog had no descrioptions. Is this just a coincidence?
Are lines 724 and 734 correct?
Padraig
On 01/18/10 14:45, Michal Pryc wrote:
Hello,
The webrev:
http://cr.opensolaris.org/~migi/13858_v1
Fixes bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=13858
This webrev changes few things:
-----------------------
1. For "Update All" the confirmation dialog may contain 3 parts for
install/update and remove packages. This does not happen for install
or remove action, as the packages can be selected only for one
action at the time. That is why if the "Update All" action was
choosen we need to recalculate the width of the install/update or
remove frames.
I did gave a try with different width and number of packages and
came up with the algorithm:
If there are all three widgets for install, update and remove then
we show them with the (default_height/4)*2, if there are two of
them, then we are showing with the (default_height/3)*2, otherwise
we are showing with the default_height (for one widget case).
-----------------------
2. The "Name" column in the confirmation dialog now have the minimum
size (150px) and ellipsize property which gaves three dots [...] if
the name is longer then the minimum size. Also this column is now
resizable so the user have the opportunity to see the full name.
Having this we do have now much more space for the description
column, which is also resizable.
--
best
Michal Pryc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
