On Tue, Jan 19, 2010 at 05:26:13PM -0800, Brock Pytlik wrote: > [email protected] wrote: > >On Tue, Jan 19, 2010 at 04:47:46PM -0800, Brock Pytlik wrote: > >>Webrev: > >>http://cr.opensolaris.org/~bpytlik/ips-9970-v1/ > > > >attribute.py: > > > > - lines 83 and 86: isinstance can be an expensive check. If this code is > > in > > the indexing fast path is there another way to re-write these > > methods that might be faster? > I'm open to suggestions, but no, I don't know of another way to > write this code given that either lists or strings could be > contained in that spot, and our choice of what to do varies greatly > on the answer. Also, from my past experiments with performance > testing indexing, I don't remember it being other than disk/parsing > bound.
Okay, I couldn't come up with anything better after consulting the internet but I thought I should ask anyway. What you have is fine with me then. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
