On 01/19/10 07:10 PM, [email protected] wrote:
On Tue, Jan 19, 2010 at 05:04:54PM -0600, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issue:
3005 some pkg verify errors should be warnings or informational messages
webrev:
http://cr.opensolaris.org/~swalker/pkg-3005/
Just a few nits:
file.py:
- line 235: can we change the endswith to endswith("/bobcat"). There's
actually a bobcat in the packages now and we should probably detect
that:
pkg search -r bobcat
INDEX ACTION VALUE PACKAGE
basename file usr/gnu/share/terminfo/b/bobcat
pkg:/[email protected]
<...>
I must correct that immediately! :)
legacy.py:
- lines 37, 107, and 159: You could eschew the stat module altogether
in this file and simply write these lines as
os.stat(pkginfo).st_nlink instead.
I prefer to eschew obfuscation, but in this case, I'll eschew stat as well.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
