This looks good to me.

Padraig

On 01/21/10 16:42, John Rice wrote:
Padraig O'Briain wrote:
Previously we had finally in a separate try statement. Do I understand correctly this is no longer necessary?
Yep as Shawn mentioned its a 2.5+ feature

Should the calls to set_busy_cursor and unset_busy_cursor be in an idle handler as __show_package_info is in a separate thread?
Yep they should, thanks.

http://cr.opensolaris.org/~jmr/13062_entire_details_21Jan_440pm/
13062 Getting package details for entire package takes a long time

JR

Padraig

On 01/21/10 15:31, John Rice wrote:
Hi - this is just a simple webrev to activate a busy cursor when fetching package dependency information using the api.info() api call. When doing so for entire in opensolaris it takes around 30 secs on my Mac Book Pro (4 Gig Ram), so we need to indicate to the user that the app is actually doing something and not frozen.

http://cr.opensolaris.org/~jmr/13062_entire_details_21Jan_320pm/
13062 Getting package details for entire package takes a long time*

*I have filed a separate performance bug 14037 against the api to see if anything can be done to speed this fetching up.

JR

Note: pylint is barfing on this as the finally as part of the try except is a 2.5 feature.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to