Hi Danek,

On Fri, 2010-01-22 at 10:04 -0800, Danek Duvall wrote:
> I was just wondering if we needed that behavior anymore,
> but I'm thinking we probably do.  I see you didn't remove either rule in
> your updated webrev, and that's fine.

I hadn't updated the webrev yet - had been trying to work out the weird
importer behaviour today, but no problem, I can put that target back.

I've worked out what was breaking for me earlier. The below fails,
resulting in 0 packages being published

687 $(UNBUNDLED_CLUSTERS): unbundleds/$$(@:%.import=%)
688         $(SOLARIS.PY) -d -s $(REPO) $(ALL_PKGS:%=-w %) $(ELIDED_FILES:%=-D 
%) \
689                 $(INCLUDE_PATH_$(BUILDID):%=-I %) \
690                 $(REF_URIS:%=-R %) unbundleds/$(@:%.import=%) \
691                 $(UNBUNDLED_TARGETS:%.import=unbundleds/%)

whereas removing line 691 from the Makefile results in us successfully
publishing the clusters.

So, this fails:

t...@tcx2200m2-02[748] make -e BUILDID=111a Clusters.import
PYTHONPATH=../../../proto/root_i386/usr/lib/python2.6/vendor-packages  
./importer.py -b 0.111a  -T \*.py   -G reboot              -G smf_manifests  -G 
fonts  -G gnome  -G variants  -m ARCH=i386         -m ARCH32=i86   -m 
ARCH64=amd64         -m i386_ONLY=''         -m sparc_ONLY=#  -p 
../../../proto/root_i386  -d -s http://localhost:12000 -w 
../../../packages/i386                           -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osolub/i386  -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osolub/all  -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osol0906/all  -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osol0906/i386                   
     -w /net/netinstall.sfbay/export/nv/x/111a/Solaris_11/Product -w . -D 
boot/solaris/devicedb/master       -D etc/hba.conf                         -D 
etc/ima.conf                         -D etc/inet/services            -D 
etc/mpapi.conf -D etc/security/auth_attr             -D etc/security/exec_attr  
             -D et
 c/security/prof_attr               -D etc/user_attr \
        -I
111a:111:110:109:108:107:106:105:104:103:102:101a:101:100a:99:98:97:96:95:94:93:92:91:90:89:88:87:86:85:84:83:82:81:80:79b:78:77:76:75a:73:72:71:00
 \
        -R http://ipkg.sfbay/rele...@[email protected],5.11-0.111
unbundleds/Clusters \
        unbundleds/ClusterTools  unbundleds/ClusterTools8
unbundleds/DTraceGUI    unbundleds/Eclipse
unbundleds/ExuberantCTags       unbundleds/GlassFishV2
unbundleds/GnuDevTools  unbundleds/LDomsManager
unbundleds/MessageQueue41       unbundleds/NetBeans
unbundleds/OpenDS               unbundleds/OpenJDK7
unbundleds/OpenOffice   unbundleds/Studio
unbundleds/Webstackui
First pass: initial import 2010-01-22 10:14:28.537824

and this doesn't

t...@tcx2200m2-02[748] make -e BUILDID=111a Clusters.import
PYTHONPATH=../../../proto/root_i386/usr/lib/python2.6/vendor-packages  
./importer.py -b 0.111a  -T \*.py   -G reboot              -G smf_manifests  -G 
fonts  -G gnome  -G variants  -m ARCH=i386         -m ARCH32=i86   -m 
ARCH64=amd64         -m i386_ONLY=''         -m sparc_ONLY=#  -p 
../../../proto/root_i386  -d -s http://localhost:12000 -w 
../../../packages/i386                           -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osolub/i386  -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osolub/all  -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osol0906/all  -w 
/net/paradise.sfbay/export/integrate_dock/nv/nv_osol0906/i386                   
     -w /net/netinstall.sfbay/export/nv/x/111a/Solaris_11/Product -w . -D 
boot/solaris/devicedb/master       -D etc/hba.conf                         -D 
etc/ima.conf                         -D etc/inet/services            -D 
etc/mpapi.conf -D etc/security/auth_attr             -D etc/security/exec_attr  
             -D et
 c/security/prof_attr               -D etc/user_attr \
        -I
111a:111:110:109:108:107:106:105:104:103:102:101a:101:100a:99:98:97:96:95:94:93:92:91:90:89:88:87:86:85:84:83:82:81:80:79b:78:77:76:75a:73:72:71:00
 \
        -R http://ipkg.sfbay/rele...@[email protected],5.11-0.111
unbundleds/Clusters

I think that specifying all of the manifests for the various unbundled
packages was needed before when publishing the clusters, whereas now,
since we're referring to the repository where they reside, it's not.  

That said, I'm not 100% sure why leaving that stuff on the command line
is preventing publication of packages.  I'll look into it some more on
Monday, and update the webrev once I'm sure of what's going on.

        cheers,
                        tim

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to