Dan, On Wed, Jan 27, 2010 at 02:10:23PM -0800, Dan Price wrote: > J-- looking back at this webrev, I am reminded that one thing > which might be worth looking at is whether flyweight would help > if applied to the Version object itself-- perhaps minus the > timestamp. > > That is to say, we probably have a lot of instances of Version > which are: 0.5.11,5.11-0.130:<something> and flyweighting up one level > (instead of or in addition too what you have now) might be at least > worth trying. Sorry I forgot to mention this yesterday, I had forgot > that I was planning to look into this.
The Version object contains up to three DotSequence objects as well as the timestring. The timestring is passed in to the Version during __init__() as part of the version_string. With this change, the only unique portion of the Version object is the timestr. The other objects in the Version are flyweights of the DotSequence. Did I misunderstand what you're proposing? -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
