Reviewed offline with Padraig, tested generated p5i with mixture of alias and non alias pubs. Got Padraig to adjust output in confirmation dialog to show prefix as well as alias. All working fine.

+1

JR

Padraig O'Briain wrote:
I have spun webrev, http://cr.opensolaris.org/~padraig/ips-14199-v3/ to change how publisher is displayed in Export Selections dialog.

Padraig

On 01/28/10 08:13, Padraig O'Briain wrote:
Joanie,

Thanks for catching this.
I have fixed __get_min_list_from_search().

I have spun another webrev, http://cr.opensolaris.org/~padraig/ips-14199-v2/.

Padraig

On 01/28/10 02:17, Joanmarie Diggs wrote:
Hey Padraig.

For some reason, this seems to be impacting my ability to search. With
current gate, if I use PM to search for 'accerciser' I get a result of
SUNWgnome-a11y-poke as expected. With your webrev applied, I get 0
results.

If I then attempt to repeat the search (by moving focus to the Search
entry and pressing Return), I get the following error in the terminal
from which I launched PM:

        Exception pycurl.error: error('curl object not on this
        multi-stack',) in <bound method StreamingFileObj.__del__ of
        <pkg.client.transport.fileobj.StreamingFileObj object at
        0xdd6fa2c>> ignored

During the initial search, however, I don't see any errors.

Take care.
--joanie

On Wed, 2010-01-27 at 20:34 +0000, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-14199-v1/, fixes
14199 Export Selections does not work if publisher has alias

The webrev ensures that a publisher prefix is used when exporting to a p5i file. When storing list of selected packages we store the publisher prefix for the package so that it does not need to be changed if alias is changed.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to