On 01/29/10 04:44 PM, [email protected] wrote:
Okay. Hopefully this is the last time this fix needs a major overhaul.
http://cr.opensolaris.org/~johansen/webrev-14240-4/
modules/client/transport/engine.py:
line 502: i don't think this check is right; did you mean:
entry = (url, uuid)
if entry not in self.__orphans:
self.__orphans.append(entry)
Why not use a dict instead here?
modules/client/transport/fileobj.py:
line 49: why use the 128-bit int instead of the hex string? memory
usage?
Otherwise, this seems fine.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
