[email protected] wrote:
On Tue, Feb 02, 2010 at 07:11:48PM -0800, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-14110-v1/
Just a few nits:
- line 37: "Exception that is raised when a uses a relative path..."
I think you're missing a noun after the a.
Thanks
- lines 95-97: In this case you're hard-coding the fact that /bin is a
symlink to /usr/bin. Would it be better to check to see if /bin is
a directory, and change this to the contents of the symlink if it is
not?
Once we have the broader implementation of symlink support in pkgdepend,
that's what will happen. It's not guaranteed that what /bin is on your
system has any relation to what is being generated/resolved on. We have
this pure hack here because it handles by far the most common case and
gives us parity with the importer.
Brock
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
