[email protected] wrote:
Folks, While looking at Shawn's code review this afternoon, I found a small bug in the transport. The fix is simple, and is attached as a diff below. Essentially, the client should be recording errors but either isn't recording the error, or it isn't recording the error as a content error.diff -r 6ce1b6def0d3 -r 351ef0eb85e2 src/modules/client/transport/transport.py --- a/src/modules/client/transport/transport.py Wed Feb 03 15:54:31 2010 -0800 +++ b/src/modules/client/transport/transport.py Wed Feb 03 17:16:46 2010 -0800 @@ -469,7 +469,7 @@ try: self._verify_catalog(s, download_dir) except tx.InvalidContentException, e: - repostats.record_error() + repostats.record_error(content=True) failedreqs.append(e.request) failures.append(e) if not flist: @@ -606,6 +606,8 @@ exc = tx.TransferContentException(url, "zlib.error:%s" % (" ".join([str(a) for a in e.args]))) + repostats = self.stats[url] + repostats.record_error(content=True) if exc.retryable: failures.append(exc) else: Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
+1 Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
