[email protected] wrote:
On Thu, Feb 04, 2010 at 11:18:52AM -0800, Brock Pytlik wrote:
Updated webrev:
http://cr.opensolaris.org/~bpytlik/ips-12271-v2/
Only change is to cleanup the test case for a timestamp issue.
Need one more set of eyes on this please,
I'm curious why you added the function strip_consecutive_dups(). It
looks like you're generating all of the tuples, and then making another
O(N) pass across the list to make them unique. Perhaps I'm missing
something crucial, but can't you simply check that lines[-1] != line
before appending lines to line on 1798?
Partially because I didn't think of changing it down there.
Produce lines is shared by search and contents. I wanted to target this
solution to search
and only search since we haven't had a request to remove duplicate lines
from pkg contents. I'm willing to make the change you suggested if we
agree we want that functionality in contents. It will also mean adding
another argument to produce lines so that it works to compare against
the previous result as well.
I can also add an argument to produce_lines so that it optionally does
the check if we don't want the feature for pkg contents.
Brock
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
