Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-9123/
actions/__init__.py:
- line 163: "wahat" -> "what"
file.py:
- line 190: What's an example of a mode that's an integer, but os.chmod()
will raise an EnvironmentError on?
- line 205: why call validate() here, since validate() only looks at
mode, which isn't involved in this operation?
- line 226: ditto here. And why don't use pass the fmri argument?
imageplan.py:
- line 1086: leftover debugging?
- line 1103: shouldn't we do the same here as we're now doing for
pkg.actions.ActionErrors?
t_action.py:
- Probably should add a test explicitly for a non-octal mode.
Seems like there's a good deal of copied code between t_pkg_info.py,
t_pkg_install.py, and t_pkg_api_install.py. Can that be cleaned up?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
