On 02/11/10 01:22 PM, Brock Pytlik wrote:
Shawn Walker wrote:
The following webrev contains fixes for the following issue (3 lines,
but webrev posted for clarity):

14515 client can traceback during search

webrev:
http://cr.opensolaris.org/~swalker/pkg-14515/

I'd like to add a unit test for this, but can't think of a good way to
do so since it is a timing-related failure.

Cheers,
LGTM
How's it timing related?

From what I see in the code, the assert would only fail if res is empty or undefined, and that would only happen if page_again is True?

If you could help explain the "res or consec_dup_lines" that would help me formulate a test case since all the current tests pass already.

--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to