On 12/02/2010 09:58, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-14537-v1/,
14537 PM hangs when installing a package via Webinstall and Orca is running

After adding new publishers, the installation of packages is now started in the main thread.
Padraig,
I believe it's better to put gobject call in the repository.py:

So change the:
                        elif self.webinstall_new:
                                gobject.idle_add(
                                   self.__g_on_add_publisher_delete_event,
                                   self.w_add_publisher_dialog, None)
                                self.parent.reload_packages()

To:

                        elif self.webinstall_new:
                                gobject.idle_add(
                                   self.__g_on_add_publisher_delete_event,
                                   self.w_add_publisher_dialog, None)
gobject.idle_add(self.parent.reload_packages)

This will be consistent with other calls from this module.
--
best
Michal Pryc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to