Folks, The following is a small code review for a bug that can result in a missed wakeup in the cancelation path.
The full details are available in the bug report: http://defect.opensolaris.org/bz/show_bug.cgi?id=14568 The good news is that this is a simple one line fix. I've included the diff, since this is small and the bug was caused my an accidental mis-merge, not anything more complicated. diff -r 01bb68a42354 src/modules/client/api.py --- a/src/modules/client/api.py Thu Feb 11 14:31:25 2010 -0800 +++ b/src/modules/client/api.py Fri Feb 12 18:50:19 2010 -0800 @@ -1744,7 +1744,6 @@ self.__canceling = True # Wait until the cancelled operation wakes us up. self.__cancel_cv.wait() - self.__canceling = False self.__cancel_lock.release() return True Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
