Tim Foster wrote: > On Mon, 2010-02-15 at 09:22 -0800, Danek Duvall wrote: > > > http://cr.opensolaris.org/~timf/14339-pkgsend > > Thanks for the review Danek, > > > t_pkgsend.py: > > > > - line 379, 393: Please be specific about the error(s) you want to ignore > > -- I assume that's pretty much just ENOENT. > > Yep, I should have been explicit. I'm really catching EEXIST - for cases > where, when processing a "f" entry, we os.makedirs() the dirname of a > file path in order to store the file there, then further on, process a > directory entry, "d" that causes us to try to remake the directory.
The new webrev catches OSError, but still doesn't re-raise if the errno isn't EEXIST. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
