On 02/19/10 08:17 PM, [email protected] wrote:
On Fri, Feb 19, 2010 at 08:03:47PM -0600, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issue:
14176 copytree callers must catch shutil.Error and not traceback
webrev:
http://cr.opensolaris.org/~swalker/pkg-14176/
This looks fine. The only comment that I have is that in a couple of
places you use statements like this:
type(e.args[0]) == list:
or
if type(entry) == tuple:
I had thought that we generally wrote this as isinstance(entry, tuple)
or isinstance(e.args[0], list).
I'm fine with either, but I'd prefer that we be consistent. Does our
language nurse have any comment on which style is preferred?
I'm specifically checking for a list or tuple here as opposed to a
sub-class of one. In this particular case, it's due to some odd error
handling that shutil uses that I'm trying to detect and account for.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
