On 02/22/10 01:31 PM, Bart Smaalders wrote:
On 02/22/10 00:34, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
14702 file action removal fails if file is missing and original_name
is set
14715 tests needed to ensure missing, preserved files don't cause
operation failure
webrev:
http://cr.opensolaris.org/~swalker/pkg-14702/
Change Summary:
* adds tests to ensure that a missing file won't cause preserve logic to
fail
* fixes original_name to not fail during action removal if original file
is missing
* adds tests to ensure that a missing directory don't cause action
removal to fail
* ensures that if a file action has changed between package versions,
but the file is missing (not on-disk) that the file will be installed
(this helps with preserve, rename, etc.)
Cheers,
Thanks for doing this....
file.py, line 454: should this not be
if saved_name is not None:
although we're not consistent w/ this.
I think you meant "if saved_name is None", but sure.
At some point, the logic in this action needs to be cleaned up
as it's gotten rather confusing. __check_preserve returns
False, True, None, "renameold", "renamenew" for example.
Agreed; I've filed:
14736 file action original_name and preserve logic could be simplified
...for this.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
