On 02/25/10 11:23, Michal Pryc wrote:
Padraig,

Should we check in the:

1275 1276          def __handle_search_all_publishers(self, term):

If the term is None (the first state of the self.previous_search_text variable) ?

I am not sure if this check is necessary.

The only way that the term could be None is if the text passed to __setup_search_zero_results is None. self.previous_search_text is set when the link INTERNAL_SEARCH_ALL_PUBS is set up. My view is that the check is not necessary.

Padraig


best
Michal Pryc


On 22/02/2010 15:05, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-14712-v1/, fixes
14712 Search in all publishers causes traceback

The problem occurs when the user searches for a string in one publisher, finds no results, clears the search entry field and requests that the search be done for all publishers.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to