Michal,
I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-13994-v4/, to address your
comments. I have also put the package names in alphabetic order, as
suggested by Rich.
Padraig
On 02/25/10 11:28, Michal Pryc wrote:
Padraig,
Two comments:
gui_pylintrc (please update the copyright date)
misc.py:
67 +# Dictionary which converts old package names to current name.
68 +package_name = { 'SUNWipkg' : 'package/pkg', \
69 + 'SUNWipkg-gui' :
'package/pkg/package-manager', \
70 + 'SUNWipkg-um' :
'package/pkg/update-manager', \
71 + 'SUNWpython26-notify' :
'library/python-2/python-notify-26', \
72 + 'SUNWcs' : 'SUNWcs' }
Do we need "\" at the end of each line? Also the spacing seems wrong,
the following lines should have 4 spaces I can count 17.
best
Michal Pryc
On 23/02/2010 08:13, Padraig O'Briain wrote:
On 02/22/10 15:31, Rich Burridge wrote:
On 02/22/10 06:00, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-13994-v2/, fixes
13994 References to package names may need to change
This webrev removes references to old package names and replaces
them with the new names.
Thanks for creating a dictionary. Why didn't you put the SUNWcs
entry in there
too? I know it's not renamed yet, so just use the old name for the
value. Then
when it gets renamed, it's easy to see where the change needs to be.
I respoun the webrev,
http://cr.opensolaris.org/~padraig/ips-13994-v3/, for this.
Also what effect does having a non-translatable "Place Holder"
string have?
Does the user ever see this?
Different strings are displayed in the label but the string which was
in the glade file was never displayed which is why I removed it.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
