Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 14832 pkg info traceback for renamed packages with no > variant-applicable dependencies > 14866 missing info retrieval unit tests for renamed packages > > webrev: > http://cr.opensolaris.org/~swalker/pkg-14832/
So now if the package is marked renamed, it'll show up as "State: ... (Renamed)", but there won't be a "Renamed to:" line. Should we have that line, but have it be empty? If so, then I think all you have to do is change pi.dependencies[0] to pi.dependencies[0:1] (assuming that we get back an empty iterable instead of None, if there aren't any dependencies). I'm a bit sketched out by the fact that you're groping through the raw action strings, rather than converting to actions, so it's good to see this change for the renamed case. Care to fix the obsolete case, too? The other tests in api.t_api_info.py are missing from baseline.txt. Should you bother adding this one? I presume at some point we should get rid of all passing tests from that file. Might it not be safer to create an image with a dummy variant, rather than relying on the arch variant? Is [email protected] actually used anywhere in test_2_renamed_packages? Is it worth having a test where renamed is explicitly set for the current architecture but the depend target is explicitly set for the opposite? line 456 (in the api test): no need for a continuation character inside parens. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
