On 03/ 1/10 02:24 AM, [email protected] wrote:
The following webrev contains fixes for the following issues:
14867 pkg(1) usage message doesn't match man page
webrev:
http://cr.opensolaris.org/~swalker/pkg-14867/
Looks great. I just noticed a few things.
In both files, you list "(-p|--publisher)" (once in client.py, twice in
pkg.1.txt). Did you mean to use square brackets here?
No, it's a required parameter and I was trying to express that you had
to specify either -p or --publisher. Is there a better way to do that?
In both files, there are inconsistencies with parameters that are
multi-valued. In some cases, you have spaces between then and the "|"
separator and in some cases they are jammed together.
For example, in all three places for image-create there is
[-g uri| --origin=uri ...]
rather than
[-g uri | --origin=uri ...]
Fixed.
Another is the above "-p|--publisher".
In client.py, under "pkg search" in the usage you refer to "server"
while pkg.1.txt refers to it twice as "repo_uri".
Changed to repo_uri.
In client.py, the facet_spec for "image-create" lists "True,False"
rather than "True|False" (or "True | False").
Fixed.
Around line 565 of pkg.1.txt, the "[--search-after publisher]" is split
across two lines (unlike the earlier mention).
Fixed.
(Nit, they're also in a different order than the earlier listing).
In pkg.1.txt, under both "change variant" sections you include a second
"[<variant_spec>=<instance> ...]" where simply including a " ..." after
the first mention of "<variant_spec>=<instance>" is sufficient (and
what's in the usage).
Fixed.
New webrev (diff against 1st):
http://cr.opensolaris.org/~swalker/pkg-14867-2/
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
