Hey all, I'd like code review for:
14870 should strip dependency debugging information Webrev: http://cr.opensolaris.org/~richlowe/pkg_14870/ This will be aiming for integration after the gate has loosened back up following, I presume, the release. This change introduces a -v flag to 'pkgdepend resolve', which if specified indicates that the pkg.debug.depend.* attributes should -remain-, the default behaviour is to stripping them. These attributes have not been documented, and Brock states in the bug that they are internal and for debugging purposes so I think that removing them by default is both not harmful and generally correct. I'm not particularly wedded to the specific option flag, suggestions are welcome. I had considered using -D to indicate debug, but it seemed unwise to take an option already used in the 'generate' subcommand for another purpose. This also fixes the 'pkgdepend resolve' usage message, which erroneously contained an upper-case 'M', fixes a crash referencing the unbound 'manf' at pkgdepend.py:222, and removes unused variables in t_pkgdep.py. The latter two changes were made to appease pylint, I'll file separate bugs for these if that's desired. In addition to the changes made to t_pkgdep.py to test in specific, and the necessity of adding -v to prevent other failures, I've built onnv using these pkg bits, and verified that dependency debug information was no longer present in the manifests. Thanks, -- Rich _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
