Shawn Walker wrote: > On 03/15/10 05:44 PM, Danek Duvall wrote: > >Shawn Walker wrote: > > > >>http://cr.opensolaris.org/~swalker/pkg-mem/ > > So the previous behaviour in this area was actually a bug. The > __get_catalog method was intended to always bypass the normal caching > mechanism so the callers like image.get_last_modified() could get the > actual on-disk last modification date without affecting or using any > cached information. The comment for the get_last_modified() states > this already.
Though as far as I can tell, get_last_modified() did get uncached data, but essentially forced the data to be cached, or re-cached unnecessarily. So this doesn't change the correctness of get_last_modified(), just the consequent, memory-hogging behavior. > The change was related to the memory usage reduction in that it was > causing any code that executed after a call to get_last_modified() to > have to reload catalog data again when it didn't need to. Wait, isn't that the new behavior, now that get_last_modified() doesn't call a method that caches the catalog? > I'll be happy to open a separate bug and add it to this changeset's > commit comment if you'd like. No need; just mention this change in the bug. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
