On 03/25/10 09:16 AM, Liane Praza wrote:
I'm really embarrassed.  Please review the fix for:

15356 fix for 15346 breaks just_these_pkgs

at:
http://cr.opensolaris.org/~lianep/pkg-re/

The fix is as minimal as possible, since I'm worried about introducing
other breakage. Testing looks good so far, though.

So I don't understand the comment about the list being pruned previously.

I almost thought the block was redundant last night when I looked at this, but then I noticed that while the pkgdict gets pruned initially, afterwards, dependencies can be added back to pkgdict again which might cause the need for it to be pruned again.

I'm also confused about the else clause causing just_these_pkgs to be ignored since the eliding happened before that.

What did I miss?

--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to