I'd like code review for:
14869 pkgdepend shouldn't include the timestamp in resolved dependencies
Webrev:
http://cr.opensolaris.org/~richlowe/pkg_14869
This uses short FMRIs (.get_short_fmri(), pkg:/[email protected]) in
dependencies generated by pkgdepend(1). It also fixes an issue in
dependencies.resolve_deps() where the loop over packages on the
installed system would use the wrong package variants.
This is done both for explicit manifests and those from the image in
which pkgdepend is running, though the former are unlikely to contain
timestamps. This necessitated changes to PkgFmri() to allow
get_short_fmri() to work correctly with version-less FMRIs.
We've gone back and forth about whether the short_fmri() is really the
right thing, due to it missing the build-release field. Agreement last
I knew it was that this was correct (it is also what the importer seems
to have done, as of b134).
I've also cleaned up pylint warnings about pkg_vars being passed down
through helper, and similar, but never referenced.
Thanks,
-- Rich
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
